Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Jun 25, 2025

This way all non-torque-control-related things should work on software versions not supporting torque control

ToDo:

  • Add tests for torque_control on different robot versions We test that the not-including part works. For the include part we'll have to wait for a released URSim with torque_control support.

@urfeex urfeex requested review from a team and removed request for a team June 25, 2025 13:14
@urfeex urfeex marked this pull request as draft June 25, 2025 13:14
@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (torque_control@5b55989). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/control/script_command_interface.cpp 90.00% 1 Missing ⚠️
src/ur/ur_driver.cpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             torque_control     #348   +/-   ##
=================================================
  Coverage                  ?   76.72%           
=================================================
  Files                     ?       92           
  Lines                     ?     4214           
  Branches                  ?      459           
=================================================
  Hits                      ?     3233           
  Misses                    ?      747           
  Partials                  ?      234           
Flag Coverage Δ
start_ursim 81.57% <ø> (?)
ur20-latest 74.61% <78.57%> (?)
ur5-3.14.3 74.85% <78.57%> (?)
ur5e-10.7.0 69.76% <78.57%> (?)
ur5e-5.9.4 74.70% <78.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urfeex urfeex marked this pull request as ready for review June 26, 2025 09:13
@urfeex urfeex requested a review from urmahp June 26, 2025 09:13
@urfeex urfeex requested a review from urmahp July 1, 2025 07:21
@urfeex urfeex force-pushed the conditional_torque_control branch from 1b8fa36 to 866449e Compare July 3, 2025 09:11
@urfeex urfeex requested a review from urmahp July 3, 2025 09:12
@urfeex
Copy link
Member Author

urfeex commented Jul 3, 2025

I've rebased this on #351 merged into torque_control. @urmahp could you please have another look?

@urfeex urfeex merged commit 46c1dd6 into UniversalRobots:torque_control Jul 3, 2025
15 of 27 checks passed
@urfeex urfeex deleted the conditional_torque_control branch July 3, 2025 11:56
urfeex added a commit to urfeex/Universal_Robots_Client_Library that referenced this pull request Nov 4, 2025
…versalRobots#348)

This way all non-torque-control-related things should work on software
versions not supporting torque control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants